Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gcr and missing dependencies #12

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

jssotomdz
Copy link
Contributor

build was failing due to a missing gcr-4 dependency. Adding that uncovered some other missing dependencies and the need for a layout binding to handle webkitgtk

@jssotomdz jssotomdz requested a review from kenvandine October 13, 2023 15:31
Copy link
Member

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to hardcode arch paths

snapcraft.yaml Outdated Show resolved Hide resolved
@jssotomdz jssotomdz force-pushed the jssotomdz/gcr-and-deps branch from b9823b1 to 19a9e6d Compare October 14, 2023 00:55
@jssotomdz jssotomdz force-pushed the jssotomdz/gcr-and-deps branch from 19a9e6d to 0332e81 Compare October 14, 2023 00:56
Copy link
Member

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@kenvandine kenvandine merged commit f773548 into ubuntu:stable Oct 14, 2023
1 check passed
@jssotomdz jssotomdz deleted the jssotomdz/gcr-and-deps branch November 8, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants